From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH xen v3] xen: arm: fully implement multicall
	interface.
Date: Thu, 17 Apr 2014 15:00:05 +0100
Message-ID: <534FDE65.3050807@linaro.org>
References: <1397739444-31407-1-git-send-email-ian.campbell@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1397739444-31407-1-git-send-email-ian.campbell@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: keir@xen.org, stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 04/17/2014 01:57 PM, Ian Campbell wrote:
>  void do_multicall_call(struct multicall_entry *multi)
>  {
>      arm_hypercall_fn_t call = NULL;
> @@ -1176,9 +1196,13 @@ void do_multicall_call(struct multicall_entry *multi)
>          return;
>      }
>  
> +    if ( is_32bit_domain(current->domain) &&
> +         !check_multicall_32bit_clean(multi) )
> +        return;
> +

With this solution, you continue to go through the other multicall.
Shouldn't we return an error here and exit the loop in do_multicall?

-- 
Julien Grall