From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: keir@xen.org, stefano.stabellini@eu.citrix.com, tim@xen.org,
xen-devel@lists.xen.org
Subject: Re: [PATCH xen v3] xen: arm: fully implement multicall interface.
Date: Thu, 17 Apr 2014 15:24:56 +0100 [thread overview]
Message-ID: <534FE438.3000003@linaro.org> (raw)
In-Reply-To: <1397744033.24638.302.camel@kazak.uk.xensource.com>
On 04/17/2014 03:13 PM, Ian Campbell wrote:
> On Thu, 2014-04-17 at 15:00 +0100, Julien Grall wrote:
>> On 04/17/2014 01:57 PM, Ian Campbell wrote:
>>> void do_multicall_call(struct multicall_entry *multi)
>>> {
>>> arm_hypercall_fn_t call = NULL;
>>> @@ -1176,9 +1196,13 @@ void do_multicall_call(struct multicall_entry *multi)
>>> return;
>>> }
>>>
>>> + if ( is_32bit_domain(current->domain) &&
>>> + !check_multicall_32bit_clean(multi) )
>>> + return;
>>> +
>>
>> With this solution, you continue to go through the other multicall.
>> Shouldn't we return an error here and exit the loop in do_multicall?
>
> See the previous discussion with Jan on v2, calling domain_crash will
> cause do_multicall to be preempted.
I missed this part sorry.
Acked-by: Julien Grall <julien.grall@linaro.org>
--
Julien Grall
prev parent reply other threads:[~2014-04-17 14:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 12:57 [PATCH xen v3] xen: arm: fully implement multicall interface Ian Campbell
2014-04-17 12:57 ` [PATCH linux v3] arm: xen: implement multicall hypercall support Ian Campbell
2014-04-24 12:03 ` Ian Campbell
2014-04-24 12:29 ` David Vrabel
2014-04-24 14:02 ` Ian Campbell
2014-04-25 17:17 ` Stefano Stabellini
2014-04-28 9:27 ` Ian Campbell
2014-05-09 14:56 ` Stefano Stabellini
2014-05-09 15:07 ` Ian Campbell
2014-05-09 16:13 ` Stefano Stabellini
2014-05-09 16:16 ` Ian Campbell
2014-04-17 14:00 ` [PATCH xen v3] xen: arm: fully implement multicall interface Julien Grall
2014-04-17 14:13 ` Ian Campbell
2014-04-17 14:24 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534FE438.3000003@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).