From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH xen v3] xen: arm: fully implement multicall interface. Date: Thu, 17 Apr 2014 15:24:56 +0100 Message-ID: <534FE438.3000003@linaro.org> References: <1397739444-31407-1-git-send-email-ian.campbell@citrix.com> <534FDE65.3050807@linaro.org> <1397744033.24638.302.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1397744033.24638.302.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: keir@xen.org, stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 04/17/2014 03:13 PM, Ian Campbell wrote: > On Thu, 2014-04-17 at 15:00 +0100, Julien Grall wrote: >> On 04/17/2014 01:57 PM, Ian Campbell wrote: >>> void do_multicall_call(struct multicall_entry *multi) >>> { >>> arm_hypercall_fn_t call = NULL; >>> @@ -1176,9 +1196,13 @@ void do_multicall_call(struct multicall_entry *multi) >>> return; >>> } >>> >>> + if ( is_32bit_domain(current->domain) && >>> + !check_multicall_32bit_clean(multi) ) >>> + return; >>> + >> >> With this solution, you continue to go through the other multicall. >> Shouldn't we return an error here and exit the loop in do_multicall? > > See the previous discussion with Jan on v2, calling domain_crash will > cause do_multicall to be preempted. I missed this part sorry. Acked-by: Julien Grall -- Julien Grall