From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v3 13/16] xen/arm: Add support for GIC v3 Date: Thu, 17 Apr 2014 16:12:23 +0100 Message-ID: <534FEF57.9060504@linaro.org> References: <1397560675-29861-1-git-send-email-vijay.kilari@gmail.com> <1397560675-29861-14-git-send-email-vijay.kilari@gmail.com> <534FA592.7060802@linaro.org> <534FB835.7070503@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Vijay Kilari Cc: Ian Campbell , Stefano Stabellini , Prasun Kapoor , Vijaya Kumar K , xen-devel@lists.xen.org, Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 04/17/2014 03:54 PM, Vijay Kilari wrote: >> I would prefer to modify GIC v2 driver rather than forking too much the >> VGIC code. The change in GIC v2 is not so difficult... > > Is it ok if we can get rid of usage fixmap in GICv2 driver to > access GICD/GICH/GICC regions > and use ioremap_nocache() similar to GICv3 driver?. I'm in favor of this solution. There is nearly no overhead compare to the FIXMAP solution. You will have to use ioremap_nocache and corresponding read/write helper. Regards, -- Julien Grall