From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= Subject: Re: [PATCH RFC 18/23] libxl: only include utmp.h if it's present Date: Thu, 17 Apr 2014 19:21:47 +0200 Message-ID: <53500DAB.1030100@citrix.com> References: <1397657612-57277-1-git-send-email-roger.pau@citrix.com> <1397657612-57277-19-git-send-email-roger.pau@citrix.com> <21328.3004.678210.533618@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Waq0r-0008Na-Ex for xen-devel@lists.xenproject.org; Thu, 17 Apr 2014 17:22:13 +0000 In-Reply-To: <21328.3004.678210.533618@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xenproject.org, Ian Campbell List-Id: xen-devel@lists.xenproject.org On 17/04/14 19:13, Ian Jackson wrote: > Roger Pau Monne writes ("[PATCH RFC 18/23] libxl: only include utmp.h if it's present"): >> Add a configure check for utmp.h presence, and gate the usage of >> utmp.h in libxl to the result of the test. > > I don't object to this, but: on FreeBSD, which header defines > login_tty then ? It's in libutil.h: http://www.freebsd.org/cgi/man.cgi?query=login_tty&apropos=0&sektion=0&manpath=FreeBSD+10.0-RELEASE&arch=default&format=html which is already included by libxl_osdeps.h. Roger.