From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= Subject: Re: [PATCH RFC 10/23] xenstored: add the FreeBSD xenstored interface Date: Tue, 22 Apr 2014 16:50:49 +0200 Message-ID: <535681C9.1030804@citrix.com> References: <1397657612-57277-1-git-send-email-roger.pau@citrix.com> <1397657612-57277-11-git-send-email-roger.pau@citrix.com> <21328.2327.566552.505120@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Wcc29-0002Rt-Vw for xen-devel@lists.xenproject.org; Tue, 22 Apr 2014 14:50:54 +0000 In-Reply-To: <21328.2327.566552.505120@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xenproject.org, Ian Campbell List-Id: xen-devel@lists.xenproject.org On 17/04/14 19:02, Ian Jackson wrote: > Roger Pau Monne writes ("[PATCH RFC 10/23] xenstored: add the FreeBSD xenstored interface"): >> This patch adds FreeBSD support to xenstored, by implementing the >> FreeBSD interface to /dev/xen/xenstored. > > Again, this is very similar to xenstored_linux.c. As is > xenstored_netbsd.c :-/. Yes, the main difference is that both Linux and NetBSD seem to use two different devices in order to get the evtchn port and to map xenstored memory. On the other hand, FreeBSD uses the same device in order to obtain the port and do the mmap. IMHO all this implementations could be easily folded into a single file with very little ifdefery, I will take a look at it. Roger.