From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v6 08/11] tools,
 libxl: parse optional start gfn from the iomem config option
Date: Tue, 22 Apr 2014 20:57:54 +0100
Message-ID: <5356C9C2.6080207@linaro.org>
References: <1398087904-16594-1-git-send-email-avanzini.arianna@gmail.com>
	<1398087904-16594-9-git-send-email-avanzini.arianna@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1398087904-16594-9-git-send-email-avanzini.arianna@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Arianna Avanzini <avanzini.arianna@gmail.com>, xen-devel@lists.xen.org
Cc: julien.grall@citrix.com, paolo.valente@unimore.it, keir@xen.org, stefano.stabellini@eu.citrix.com, tim@xen.org, dario.faggioli@citrix.com, Ian.Jackson@eu.citrix.com, Ian.Campbell@eu.citrix.com, etrudeau@broadcom.com, JBeulich@suse.com, viktor.kleinik@globallogic.com
List-Id: xen-devel@lists.xenproject.org

Hi Arianna,

On 21/04/14 14:45, Arianna Avanzini wrote:
> +            libxl_iomem_range_init(&b_info->iomem[i]);
> +            ret = sscanf(buf, "%" SCNx64",%" SCNx64"@%" SCNx64,
> +                         &b_info->iomem[i].start,
> +                         &b_info->iomem[i].number,
> +                         &b_info->iomem[i].gfn);
> +            if (ret < 2) {
> +                fprintf(stderr,
> +                        "xl: Invalid argument parsing iomem: %s\n", buf);
> +                exit(1);
>               }
>           }
>       }
>
> -
> -

Spurious change here.

>       if (!xlu_cfg_get_list (config, "disk", &vbds, 0, 0)) {
>           d_config->num_disks = 0;
>           d_config->disks = NULL;
>

Other than the minor change, FWIW:

Acked-by: Julien Grall <julien.grall@linaro.org>

Regards,

-- 
Julien Grall