From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v3 2/4] GlobalProperty: Display warning about unused -global Date: Tue, 22 Apr 2014 20:28:12 -0400 Message-ID: <5357091C.9050002@redhat.com> References: <1395705336-22528-1-git-send-email-dslutz@verizon.com> <1395705336-22528-3-git-send-email-dslutz@verizon.com> <53514312.5060705@suse.de> <5352E293.3090002@redhat.com> <5356F77F.7070504@terremark.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5356F77F.7070504@terremark.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Don Slutz , =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: xen-devel@lists.xensource.com, "Michael S. Tsirkin" , qemu-devel@nongnu.org, Anthony Liguori , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org Il 22/04/2014 19:13, Don Slutz ha scritto: >> >> Even then, I suspect sooner or later machines other than PC and Q35 >> will be versioned. At that point we'll probably want QEMU-global >> compat_props that automatically apply to all machines, even if a type >> is not missing. I think we should already approximate this behavior >> by allowing machine .compat_props where the type doesn't exist. > > If I am reading this correctly, this is asking that .compat_props to not > be reported. This currently happens because of not_used being false > in all C99 struct initializations. Oh, I see. That's obvious in retrospect, but perhaps a comment can be useful around the definition of the not_used field. Paolo