From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v4 14/18] xen/arm: IRQ: Store IRQ type in arch_irq_desc Date: Wed, 23 Apr 2014 13:26:59 +0100 Message-ID: <5357B193.3080100@linaro.org> References: <1398171530-27391-1-git-send-email-julien.grall@linaro.org> <1398171530-27391-15-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WcwGW-0006Zu-4k for xen-devel@lists.xenproject.org; Wed, 23 Apr 2014 12:27:05 +0000 Received: by mail-ee0-f53.google.com with SMTP id b57so721694eek.40 for ; Wed, 23 Apr 2014 05:27:01 -0700 (PDT) In-Reply-To: <1398171530-27391-15-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: ian.campbell@citrix.com Cc: xen-devel@lists.xenproject.org, Julien Grall , tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 04/22/2014 01:58 PM, Julien Grall wrote: > @@ -82,6 +83,12 @@ static int __cpuinit init_local_irq_data(void) > init_one_irq_desc(desc); > desc->irq = irq; > desc->action = NULL; > + > + /* PPIs are include in local_irqs, we have to copy the IRQ type from > + * CPU0 otherwise we may miss the type if the IRQ type has been > + * set early. > + */ > + desc->arch.type = per_cpu(local_irq_desc, 0)[irq].arch.type; I forgot to introduce a boot_cpu macro (as asked by Ian on v2). I will write a follow-up to remove per_cpu(..., 0) in few places if I don't need to resent this series. -- Julien Grall