From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v7 05/12] xen/arm: nr_lrs should be uint8_t Date: Wed, 23 Apr 2014 13:53:22 +0100 Message-ID: <5357B7C2.600@linaro.org> References: <1396969969-18973-5-git-send-email-stefano.stabellini@eu.citrix.com> <1398257242.18537.84.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1398257242.18537.84.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: julien.grall@citrix.com, xen-devel@lists.xensource.com, Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 04/23/2014 01:47 PM, Ian Campbell wrote: > On Tue, 2014-04-08 at 16:12 +0100, Stefano Stabellini wrote: >> A later patch is going to use uint8_t to keep track of LRs. >> Both GICv3 and GICv2 don't need any more than an uint8_t to keep track >> of the number of LRs. > > Did you confirm that this doesn't lead to inefficient loading and > masking stuff on access? > >> Signed-off-by: Stefano Stabellini >> Acked-by: Julien Grall > > If yes then: > Acked-by: Ian Campbell > > Although TBH I'm not sure why unsigned int was so harmful here. In struct irq_pending (see next patch: #6) the lr is stored using an uint8. IHMO, the both variable should have the same type to avoid mistake. -- Julien Grall