From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: Re: [PATCH v3 2/4] GlobalProperty: Display warning
	about unused -global
Date: Wed, 23 Apr 2014 08:58:05 -0400
Message-ID: <5357B8DD.7050401@terremark.com>
References: <1395705336-22528-1-git-send-email-dslutz@verizon.com>	<1395705336-22528-3-git-send-email-dslutz@verizon.com>	<53514312.5060705@suse.de>
	<5352E293.3090002@redhat.com> <5356F77F.7070504@terremark.com>
	<5357091C.9050002@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
In-Reply-To: <5357091C.9050002@redhat.com>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: xen-devel@lists.xensource.com, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, Don Slutz <dslutz@verizon.com>, Anthony Liguori <aliguori@amazon.com>, =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
List-Id: xen-devel@lists.xenproject.org


On 04/22/14 20:28, Paolo Bonzini wrote:
> Il 22/04/2014 19:13, Don Slutz ha scritto:
>>>
>>> Even then, I suspect sooner or later machines other than PC and Q35
>>> will be versioned.  At that point we'll probably want QEMU-global
>>> compat_props that automatically apply to all machines, even if a type
>>> is not missing.  I think we should already approximate this behavior
>>> by allowing machine .compat_props where the type doesn't exist.
>>
>> If I am reading this correctly, this is asking that .compat_props to not
>> be reported.  This currently happens because of not_used being false
>> in all C99 struct initializations.
>
> Oh, I see.  That's obvious in retrospect, but perhaps a comment can be 
> useful around the definition of the not_used field.
>

Will add a comment:

/**
  * GlobalProperty:
  * @not_used: Track use of a global property.  Defaults to false in all 
C99 struct initializations.
  *
  * This prevents reports of .compat_props when they are not used.
  */

(Not sure if this is the correct formatting.)

    -Don Slutz

> Paolo