From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v3 11/16] xen/arm: move vgic defines to vgic header file Date: Wed, 23 Apr 2014 16:11:25 +0100 Message-ID: <5357D81D.9010007@linaro.org> References: <1397560675-29861-1-git-send-email-vijay.kilari@gmail.com> <1397560675-29861-12-git-send-email-vijay.kilari@gmail.com> <534EB781.2070605@linaro.org> <1398265669.18537.163.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1398265669.18537.163.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: vijay.kilari@gmail.com, stefano.stabellini@eu.citrix.com, Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, xen-devel@lists.xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 04/23/2014 04:07 PM, Ian Campbell wrote: > On Wed, 2014-04-16 at 18:01 +0100, Julien Grall wrote: >> Hello Vijaya, >> >> Thank you for the patch. >> >> On 04/15/2014 12:17 PM, vijay.kilari@gmail.com wrote: >>> From: Vijaya Kumar K >>> >>> gic.h contains defines of vgic. Move these to vgic >>> header file. Also move inline functions and defines >>> in vgic.c to vgic.h >> >> Can you explain in the commit message, why you need to move theses >> functions in the header? > > Yeah, many of them look like they will really belong in either vgic.c or > vgic-v2.c. Which ones are actually used by both the generic and specific > code? > >>> +static inline int is_vcpu_running(struct domain *d, int vcpuid) >> >> >> The name of the 2 functions and 1 define are too generic. It was fine >> internally but not to be exported. > > is_vcpu_running is fine IMHO. With this name, I don't think this function should belong to vgic.h Can it be a common code function (i.e ARM & x86)? Maybe sched.h? -- Julien Grall