xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: George Dunlap <george.dunlap@eu.citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>, Lingfei Kong <lkong@redhat.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: drjones@redhat.com, vkuznets@redhat.com, leiwang@redhat.com, wshi@redhat.com
Date: Thu, 24 Apr 2014 10:01:13 +0100	[thread overview]
Message-ID: <5358D2D9.6040104@eu.citrix.com> (raw)
In-Reply-To: <1398329070.18537.243.camel@kazak.uk.xensource.com>

On 04/24/2014 09:44 AM, Ian Campbell wrote:
> On Thu, 2014-04-24 at 08:14 +0800, Lingfei Kong wrote:
>> Maybe another solution is to change the xl command to adapt this.
> Feel free to propose a patch but I suspect this would involve too much
> surgery to the config file parser.
>
>>   On
>> RHEL5 xen hypervisor, I can create a guest with `xm create hvm.cfg
>> cpus="0-3"`. As a user I prefer this method, because this will be
>> consistent with it's config file and it is strange to use ' to enclose
>> the parameters.
> That is perfectly normal shell quoting behaviour, nothing strange about
> it IMHO.

Well having the config file syntax include quotes and brackets is 
natural.  The fact that the shell interprets quotes and brackets is also 
natural.  But the combination of the two leads to a rather unexpected 
and clunky user interface.

Unfortunately I'm not sure what we can really do at this point to 
maintain the general flexibility while avoiding backticks.  We might be 
able to modify the parser for specific cases, such as the cpus one, to 
tolerate 'cpus=0-3' rather than the canonical 'cpus="0-3"'. But in the 
general case it would require re-writing the config format such that it 
can be written without requiring any characters treated specially by the 
shell; that's just a bit more work than it's really worth, I think.

  -George

  reply	other threads:[~2014-04-24  9:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <648058658.7316781.1397784467480.JavaMail.zimbra@redhat.com>
2014-04-18  1:40 ` drjones@redhat.com, vkuznets@redhat.com, leiwang@redhat.com, wshi@redhat.com Lingfei Kong
2014-04-21 13:02   ` Is: Xen 4.4 and 'cpus="X-Y" command line parsing borked Was:Re: " Konrad Rzeszutek Wilk
2014-04-22  1:33     ` Lingfei Kong
2014-04-22 10:59   ` George Dunlap
2014-04-23  0:56     ` Lingfei Kong
2014-04-23 10:58       ` George Dunlap
2014-04-24  0:14         ` Lingfei Kong
2014-04-24  8:44           ` Ian Campbell
2014-04-24  9:01             ` George Dunlap [this message]
2014-04-24  9:32               ` Ian Campbell
2014-04-24 11:27                 ` George Dunlap
2014-04-24 11:33                   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5358D2D9.6040104@eu.citrix.com \
    --to=george.dunlap@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=lkong@redhat.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).