From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v2 1/4] xen: make logdirty and iommu
 mutually exclusive
Date: Thu, 24 Apr 2014 13:57:23 +0200
Message-ID: <5358FC23.1000907@citrix.com>
References: <1398240984-67266-1-git-send-email-roger.pau@citrix.com>	<1398240984-67266-2-git-send-email-roger.pau@citrix.com>	<5357A9F9020000780000B491@nat28.tlf.novell.com>
	<5358BF17.1030801@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <roger.pau@citrix.com>) id 1WdIHS-0004iS-3m
	for xen-devel@lists.xenproject.org; Thu, 24 Apr 2014 11:57:30 +0000
In-Reply-To: <5358BF17.1030801@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, Tim Deegan <tim@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 24/04/14 09:36, Roger Pau Monn=E9 wrote:
> On 23/04/14 11:54, Jan Beulich wrote:
>>>>> On 23.04.14 at 10:16, <roger.pau@citrix.com> wrote:
>>> --- a/xen/drivers/passthrough/iommu.c
>>> +++ b/xen/drivers/passthrough/iommu.c
>>> @@ -292,7 +292,8 @@ static int assign_device(struct domain *d, u16 seg,=
 u8 =

>>> bus, u8 devfn)
>>>       * enabled for this domain */
>>>      if ( unlikely(!need_iommu(d) &&
>>>              (d->arch.hvm_domain.mem_sharing_enabled ||
>>> -             d->mem_event->paging.ring_page)) )
>>> +             d->mem_event->paging.ring_page ||
>>> +             paging_mode_log_dirty(d))) )
>>
>> I'm afraid that would return true also for non-global log dirty mode.
>> This patch series
>> http://lists.xenproject.org/archives/html/xen-devel/2014-04/msg02750.html
>> (patch 1) introduces a way to know whether global mode is enabled
>> - maybe you should base your series on top of that one?
> =

> Sure, this series are already on top of Mukesh p2m cleanup patches, I
> don't mind rebasing it on top of your series also.

I'm afraid I will have to wait for either you or Mukesh to rebase on top
of each other, since your patches don't apply cleanly on top of Mukesh's
p2m changes.

Roger.