Re: [PATCH v5 RESEND 03/17] x86/VPMU: Minor VPMU cleanup

[Boris Ostrovsky <boris.ostrovsky@oracle.com>]

On 04/26/2014 04:20 AM, Tian, Kevin wrote:
>> diff --git a/xen/arch/x86/hvm/vmx/vpmu_core2.c
>> b/xen/arch/x86/hvm/vmx/vpmu_core2.c
>> index 8aa7cb2..1e32ff3 100644
>> --- a/xen/arch/x86/hvm/vmx/vpmu_core2.c
>> +++ b/xen/arch/x86/hvm/vmx/vpmu_core2.c
>> @@ -326,10 +326,7 @@ static int core2_vpmu_save(struct vcpu *v)
>>   {
>>       struct vpmu_struct *vpmu = vcpu_vpmu(v);
>>
>> -    if ( !vpmu_is_set(vpmu, VPMU_CONTEXT_SAVE) )
>> -        return 0;
>> -
>> -    if ( !vpmu_is_set(vpmu, VPMU_CONTEXT_LOADED) )
>> +    if ( !vpmu_is_set_all(vpmu, VPMU_CONTEXT_SAVE |
>> VPMU_CONTEXT_LOADED) )
>>           return 0;
>>
>>       __core2_vpmu_save(v);
> right below you miss a bitmap check:
>
>      /* Unset PMU MSR bitmap to trap lazy load. */
>      if ( !vpmu_is_set(vpmu, VPMU_RUNNING) && cpu_has_vmx_msr_bitmap )
>          core2_vpmu_unset_msr_bitmap(v->arch.hvm_vmx.msr_bitmap);


You mean is_hvm_domain()? Yes, (although this check does appears in a 
later patch).  I'll move it here.

-boris