From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v5 RESEND 03/17] x86/VPMU: Minor VPMU cleanup
Date: Mon, 28 Apr 2014 09:52:00 -0400
Message-ID: <535E5D00.8040009@oracle.com>
References: <1398257438-4994-1-git-send-email-boris.ostrovsky@oracle.com>
	<1398257438-4994-4-git-send-email-boris.ostrovsky@oracle.com>
	<AADFC41AFE54684AB9EE6CBC0274A5D125E517E0@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <AADFC41AFE54684AB9EE6CBC0274A5D125E517E0@SHSMSX101.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: "keir@xen.org" <keir@xen.org>, "Nakajima, Jun" <jun.nakajima@intel.com>, "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>, "Dong,
	Eddie" <eddie.dong@intel.com>, "Dugger,
	Donald D" <donald.d.dugger@intel.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, "dietmar.hahn@ts.fujitsu.com" <dietmar.hahn@ts.fujitsu.com>, "JBeulich@suse.com" <JBeulich@suse.com>, "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>
List-Id: xen-devel@lists.xenproject.org

On 04/26/2014 04:20 AM, Tian, Kevin wrote:
>> diff --git a/xen/arch/x86/hvm/vmx/vpmu_core2.c
>> b/xen/arch/x86/hvm/vmx/vpmu_core2.c
>> index 8aa7cb2..1e32ff3 100644
>> --- a/xen/arch/x86/hvm/vmx/vpmu_core2.c
>> +++ b/xen/arch/x86/hvm/vmx/vpmu_core2.c
>> @@ -326,10 +326,7 @@ static int core2_vpmu_save(struct vcpu *v)
>>   {
>>       struct vpmu_struct *vpmu = vcpu_vpmu(v);
>>
>> -    if ( !vpmu_is_set(vpmu, VPMU_CONTEXT_SAVE) )
>> -        return 0;
>> -
>> -    if ( !vpmu_is_set(vpmu, VPMU_CONTEXT_LOADED) )
>> +    if ( !vpmu_is_set_all(vpmu, VPMU_CONTEXT_SAVE |
>> VPMU_CONTEXT_LOADED) )
>>           return 0;
>>
>>       __core2_vpmu_save(v);
> right below you miss a bitmap check:
>
>      /* Unset PMU MSR bitmap to trap lazy load. */
>      if ( !vpmu_is_set(vpmu, VPMU_RUNNING) && cpu_has_vmx_msr_bitmap )
>          core2_vpmu_unset_msr_bitmap(v->arch.hvm_vmx.msr_bitmap);


You mean is_hvm_domain()? Yes, (although this check does appears in a 
later patch).  I'll move it here.

-boris