From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v5 RESEND 05/17] x86/VPMU: Handle APIC_LVTPC
	accesses
Date: Mon, 28 Apr 2014 10:05:04 -0400
Message-ID: <535E6010.7020901@oracle.com>
References: <1398257438-4994-1-git-send-email-boris.ostrovsky@oracle.com>
	<1398257438-4994-6-git-send-email-boris.ostrovsky@oracle.com>
	<AADFC41AFE54684AB9EE6CBC0274A5D125E51803@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <AADFC41AFE54684AB9EE6CBC0274A5D125E51803@SHSMSX101.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: "keir@xen.org" <keir@xen.org>, "Nakajima, Jun" <jun.nakajima@intel.com>, "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>, "Dong,
	Eddie" <eddie.dong@intel.com>, "Dugger,
	Donald D" <donald.d.dugger@intel.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, "dietmar.hahn@ts.fujitsu.com" <dietmar.hahn@ts.fujitsu.com>, "JBeulich@suse.com" <JBeulich@suse.com>, "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>
List-Id: xen-devel@lists.xenproject.org

On 04/26/2014 04:20 AM, Tian, Kevin wrote:
>> From: Boris Ostrovsky [mailto:boris.ostrovsky@oracle.com]
>> Sent: Wednesday, April 23, 2014 8:50 PM
>>
>> Update APIC_LVTPC vector when HVM guest writes to it.
>>
>> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Acked-by: Kevin Tian <kevin.tian@intel.com>, with one comment.
>
>> @@ -230,18 +238,18 @@ void vpmu_initialise(struct vcpu *v)
>>       case X86_VENDOR_AMD:
>>           if ( svm_vpmu_initialise(v, opt_vpmu_enabled) != 0 )
>>               opt_vpmu_enabled = 0;
>> -        break;
>> +        return;
>>
>>       case X86_VENDOR_INTEL:
>>           if ( vmx_vpmu_initialise(v, opt_vpmu_enabled) != 0 )
>>               opt_vpmu_enabled = 0;
>> -        break;
>> +        return;
>>
>>       default:
>>           printk("VPMU: Initialization failed. "
>>                  "Unknown CPU vendor %d\n", vendor);
>>           opt_vpmu_enabled = 0;
>> -        break;
>> +        return;
>>       }
>>   }
>>
> not understand break->return change here

Hmm... I am sure there was a perfectly good reason why I did this ;-).

Perhaps at some point I had something at the end of the routine that I 
wasn't supposed to be executed if initialization failed. But it's not 
there now so I'll revert these changes (unless I find why I did this).

-boris