From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v4 14/21] xen/passthrough: iommu: Basic support of device tree assignment Date: Mon, 28 Apr 2014 15:12:11 +0100 Message-ID: <535E61BB.7060203@linaro.org> References: <1398172475-27873-1-git-send-email-julien.grall@linaro.org> <1398172475-27873-15-git-send-email-julien.grall@linaro.org> <1398693701.29700.120.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WemI3-0002un-8a for xen-devel@lists.xenproject.org; Mon, 28 Apr 2014 14:12:15 +0000 Received: by mail-ee0-f51.google.com with SMTP id c13so4859999eek.24 for ; Mon, 28 Apr 2014 07:12:13 -0700 (PDT) In-Reply-To: <1398693701.29700.120.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, Xiantao Zhang , tim@xen.org, Jan Beulich , stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 04/28/2014 03:01 PM, Ian Campbell wrote: > On Tue, 2014-04-22 at 14:14 +0100, Julien Grall wrote: >> diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c >> new file mode 100644 >> index 0000000..ae05b19 >> --- /dev/null >> +++ b/xen/drivers/passthrough/device_tree.c >> @@ -0,0 +1,111 @@ >> +/* >> + * xen/drivers/passthrough/arm/device_tree.c > > Mismatches the actual path. Please just drop this line. > >> + * >> + * Code to passthrough device tree node to a guest > > ^a > >> + * TODO: This contains only necessary code to protected device with > ^the devices passed to > >> + * dom0. It will need some updates when device passthrough will be > > s/will be/is. > >> @@ -111,6 +112,9 @@ struct dt_device_node { >> struct dt_device_node *next; /* TODO: Remove it. Only use to know the last children */ >> struct dt_device_node *allnext; >> >> + /* IOMMU specific fields */ >> + bool is_protected; /* Tell if the device is protected by an IOMMU */ > > The second comment is a bit redundant given the first command and the > filed name but if you want to keep it then either s/Tell/Tells us/ or > s/Tell/True/. I will drop it in the next version. > Apart from those nits: Acked-by: Ian Campbell Thanks! -- Julien Grall