From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v4 15/21] xen/passthrough: Introduce IOMMU ARM architecture Date: Mon, 28 Apr 2014 15:21:12 +0100 Message-ID: <535E63D8.9030205@linaro.org> References: <1398172475-27873-1-git-send-email-julien.grall@linaro.org> <1398172475-27873-16-git-send-email-julien.grall@linaro.org> <1398693895.29700.123.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WemQl-00041h-Cz for xen-devel@lists.xenproject.org; Mon, 28 Apr 2014 14:21:15 +0000 Received: by mail-ee0-f42.google.com with SMTP id d17so4952557eek.1 for ; Mon, 28 Apr 2014 07:21:13 -0700 (PDT) In-Reply-To: <1398693895.29700.123.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, Jan Beulich , tim@xen.org, Xiantao Zhang , stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 04/28/2014 03:04 PM, Ian Campbell wrote: > On Tue, 2014-04-22 at 14:14 +0100, Julien Grall wrote: >> kinfo.unassigned_mem = dom0_mem; >> >> rc = kernel_probe(&kinfo); >> + > > Please drop this new blank line. > >> if ( rc < 0 ) >> return rc; >> > >> diff --git a/xen/drivers/passthrough/arm/iommu.c b/xen/drivers/passthrough/arm/iommu.c >> new file mode 100644 >> index 0000000..5d27b35 >> --- /dev/null >> +++ b/xen/drivers/passthrough/arm/iommu.c >> @@ -0,0 +1,72 @@ >> +/* >> + * xen/drivers/passthrough/arm/iommu.c > > At least the path is right this time, but IMHO all these can be dropped. I was just following the header comment format as on the other files. Anyway, I will drop it. >> +void __init iommu_set_ops(const struct iommu_ops *ops) >> +{ >> + BUG_ON(ops == NULL); >> + >> + if ( iommu_ops && iommu_ops != ops ) >> + printk("WARNING: IOMMU ops already set to a different value\n"); > > "WARNING: Cannot set IOMMU ops, already set to a different value" ? > > Other than those nits: Acked-by: Ian Campbell Thanks! -- Julien Grall