From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v3 09/16] xen/arm: use device api to detect
	GIC version
Date: Tue, 29 Apr 2014 11:13:57 +0100
Message-ID: <535F7B65.9070606@linaro.org>
References: <1397560675-29861-1-git-send-email-vijay.kilari@gmail.com>	
	<1397560675-29861-10-git-send-email-vijay.kilari@gmail.com>	
	<1398265280.18537.161.camel@kazak.uk.xensource.com>	
	<CALicx6t83aSJ709Qs4OP7qbUBwTNNHVwqe5pKkg4oqcnDKqUaA@mail.gmail.com>
	<1398761716.4457.12.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1398761716.4457.12.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>, Vijay Kilari <vijay.kilari@gmail.com>
Cc: Prasun Kapoor <Prasun.Kapoor@caviumnetworks.com>, Vijaya Kumar K <vijaya.kumar@caviumnetworks.com>, xen-devel@lists.xen.org, Stefano Stabellini <stefano.stabellini@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org



On 29/04/14 09:55, Ian Campbell wrote:
> On Tue, 2014-04-29 at 12:37 +0530, Vijay Kilari wrote:
>> On Wed, Apr 23, 2014 at 8:31 PM, Ian Campbell <Ian.Campbell@citrix.com> wrote:
>>> On Tue, 2014-04-15 at 16:47 +0530, vijay.kilari@gmail.com wrote:
>>>> +static const char * const gicv2_dt_compat[] __initconst =
>>>> +{
>>>> +    "arm,cortex-a15-gic",
>>>> +    "arm,cortex-a9-gic",
>>>
>>> This is DT_MATCH_GIC. Please keep using it. Perhaps you will want to
>>> rename it to DT_MATCH_GICV2.
>>>
>> DT_MATCH_GIC is redefined as DT_MATCH_COMPATIBLE, so could not
>> use it here.
>> #define DT_MATCH_GIC    DT_MATCH_COMPATIBLE("arm,cortex-a15-gic"), \
>>                          DT_MATCH_COMPATIBLE("arm,cortex-a7-gic")
>
> Hrm I thought you were removing the existing use of DT_MATCH_GIC so you
> could change it, but actually one remains.
>
> A little unsatisfactory to have this list twice. Not sure what to do. At
> the least we could define DT_MATCH_GIC_COMPATIBLE and
> DT_MATCH_GIC_STRING next to each other in the same header.

We could also extend/modify the device API to accept DT_MATCH* instead 
of a list of compatible string.

I don't really like this solution but it will avoid to have 2 times the 
same list of compatible string with only minor changes.

Regards,

-- 
Julien Grall