From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: Re: [PATCH v2] tools: require OCaml version 3.09.3 or
 greater
Date: Wed, 30 Apr 2014 19:01:33 -0400
Message-ID: <536180CD.1070301@terremark.com>
References: <1392115104-22828-1-git-send-email-roger.pau@citrix.com>	
	<52FA4E4B.2000906@terremark.com>	
	<1394635854.21145.102.camel@kazak.uk.xensource.com>	
	<1398428051.18537.446.camel@kazak.uk.xensource.com>	
	<21345.4328.682258.876534@mariner.uk.xensource.com>
	<1398870617.29888.5.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <dslutz@verizon.com>) id 1WfdVT-0007eJ-6f
	for xen-devel@lists.xenproject.org; Wed, 30 Apr 2014 23:01:39 +0000
In-Reply-To: <1398870617.29888.5.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org, Don Slutz <dslutz@verizon.com>, Roger Pau Monne <roger.pau@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 04/30/14 11:10, Ian Campbell wrote:
> On Wed, 2014-04-30 at 16:04 +0100, Ian Jackson wrote:
>> Ian Campbell writes ("Re: [Xen-devel] [PATCH v2] tools: require OCaml version 3.09.3 or greater"):
>>> I have this on my list of things for backport, but it's comes under your
>>> umbrella. What do you think?
>> I looked through the past email thread and I can't see /why/ this
>> patch was applied.  The commit message doesn't explain either!
>>
>> Rather than me digging through list archives, perhaps someone could
>> enlighten me ?  If I ever knew I have forgotten ...
>  From memory something or other didn't compile with the ocaml in RHEL5,
> which was older.

I was the person that found an ocaml change that did not compile in RHEL5 (OCaml version 3.09.3)

This was done to help catch build errors.  The fix for RHEL5 was:

[BUGFIX][PATCH 1/1] xenlight_stubs.c: Allow it to build with ocaml 3.09.3

...

+/*
+ * Starting with ocaml-3.09.3, CAMLreturn can only be used for ``value''
+ * types. CAMLreturnT was only added in 3.09.4, so we define our own
+ * version here if needed.
+ */


Hope this helps.
    -Don Slutz

> Ian.
>
>