Re: [PATCH v4 11/15] autoconf: xen: move standard variables to a generic place

["Jan Beulich" <JBeulich@suse.com>]

>>> On 30.04.14 at 19:53, <mcgrof@suse.com> wrote:
> On Wed, Apr 30, 2014 at 12:52:27AM -0600, Jan Beulich wrote:
>> >>> On 30.04.14 at 03:12, <mcgrof@do-not-panic.com> wrote:
>> > This moves all generic variables to the top level makefile,
>> > tons of files use these so just make them general enough. This
>> > also paves the way to let us easily dynamically configure these
>> > with autoconf, for now we leave the same presets as was present
>> > before.
>> 
>> Am I right understanding that this then will require ./configure to
>> be run even for hypervisor-only building?
> 
> Its unclear what you mean by that, can you describe what is required
> to accomplish this on a fresh git tree. Can you describe what expectations
> you have on build time to see if this patch breaks that and if so see
> what can be done to avoid this? All the changes I did here really was
> to toss around variables to be set through autoconf and if building
> the hypervisor requries them then yes, but fixing that should be as
> easy as adding schecks to add sensible defaults if configure has not
> been run.

The main problem I see is with config/StdGNU.mk now including
config/Toplevel.mk, with the latter only being generated by the
configure process. What I expect to continue to work is "make xen"
(and - hopefully unaffected, albeit I didn't check -
"make -C extras/mini-os") without anything else done on a fresh
tree.

Jan