From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Vijay Kilari <vijay.kilari@gmail.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Vijaya Kumar K <vijaya.kumar@caviumnetworks.com>,
tim@xen.org, stefano.stabellini@citrix.com,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2] xen/arm: vcpu: Correctly release resource when the VCPU failed to initialized
Date: Wed, 07 May 2014 16:09:13 +0100 [thread overview]
Message-ID: <536A4C99.9050101@linaro.org> (raw)
In-Reply-To: <5363BB94.4060606@linaro.org>
On 02/05/14 16:36, Julien Grall wrote:
>> Was Vijay not moving the vgtic stuff out in one of the gicv3 patches?
>
> (CC him)
>
> IIRC, he only moves the private_irqs field. I think we should move the
> whole structure, to give more space for the future.
>
> This patch will be necessary for the GICv3 serie has vcpu_vgic_init will
> be able to fail (see patch #10).
>
> Ideally, for bisection purpose, it should be applied before the patch #10.
After thinking, both patch are interdependent. If I want to move out
some structure Xen will have to allocate memory. Which mean the function
can fail and leak some resources (before this patch is applied).
As we are fine for now, I will wait GICv3 patches is pushed (or another
patch related to arch vcpu initialization) before sending again this.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-05-09 8:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 19:15 [PATCH v2] xen/arm: vcpu: Correctly release resource when the VCPU failed to initialized Julien Grall
2014-05-02 12:25 ` Ian Campbell
2014-05-02 14:09 ` Julien Grall
2014-05-02 14:17 ` Andrew Cooper
2014-05-02 15:15 ` Ian Campbell
2014-05-02 15:27 ` Ian Campbell
2014-05-02 15:36 ` Julien Grall
2014-05-07 15:09 ` Julien Grall [this message]
2014-05-21 12:39 ` Julien Grall
2014-06-02 14:39 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536A4C99.9050101@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=vijay.kilari@gmail.com \
--cc=vijaya.kumar@caviumnetworks.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).