From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2] xen/arm: vcpu: Correctly release resource when the VCPU failed to initialized Date: Wed, 07 May 2014 16:09:13 +0100 Message-ID: <536A4C99.9050101@linaro.org> References: <1398885355-13200-1-git-send-email-julien.grall@linaro.org> <1399033506.32736.84.camel@kazak.uk.xensource.com> <5363A735.3020205@linaro.org> <5363A8F0.2050109@citrix.com> <1399043711.18944.6.camel@kazak.uk.xensource.com> <1399044437.18944.15.camel@kazak.uk.xensource.com> <5363BB94.4060606@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WigJu-0007mr-Gv for xen-devel@lists.xenproject.org; Fri, 09 May 2014 08:38:18 +0000 Received: by mail-we0-f176.google.com with SMTP id q59so3651352wes.35 for ; Fri, 09 May 2014 01:38:16 -0700 (PDT) In-Reply-To: <5363BB94.4060606@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Vijay Kilari , Andrew Cooper , Vijaya Kumar K , tim@xen.org, stefano.stabellini@citrix.com, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On 02/05/14 16:36, Julien Grall wrote: >> Was Vijay not moving the vgtic stuff out in one of the gicv3 patches? > > (CC him) > > IIRC, he only moves the private_irqs field. I think we should move the > whole structure, to give more space for the future. > > This patch will be necessary for the GICv3 serie has vcpu_vgic_init will > be able to fail (see patch #10). > > Ideally, for bisection purpose, it should be applied before the patch #10. After thinking, both patch are interdependent. If I want to move out some structure Xen will have to allocate memory. Which mean the function can fail and leak some resources (before this patch is applied). As we are fine for now, I will wait GICv3 patches is pushed (or another patch related to arch vcpu initialization) before sending again this. Regards, -- Julien Grall