Re: [PATCH v6] Autoconf: add variable for pass arbitrary options to qemu upstream

[Fabio Fantoni <fabio.fantoni@m2r.biz>]

Il 09/05/2014 10:28, Ian Campbell ha scritto:
> On Thu, 2014-05-08 at 12:53 -0400, Don Slutz wrote:
>> On 05/08/14 07:43, Ian Campbell wrote:
>>> On Thu, 2014-05-08 at 13:00 +0200, Fabio Fantoni wrote:
>>>> Il 08/05/2014 11:53, Ian Campbell ha scritto:
>>>>> On Tue, 2014-05-06 at 16:30 +0200, Fabio Fantoni wrote:
>>>>>> Added configure options for pass arbitrary build options to qemu
>>>>>> upstream.
>>>>>>
>>>>>> Usage example:
>>>>>> ./configure QEMUU_EXTRA_ARGS="--enable-spice --enable-usb-redir"
>>>>> Isn't
>>>>>            ./configure --with-extra-qemuu-configure-args="--enable-sss"
>>>>> more conventional for this sort of thing?
>>>> I don't know, tell me what is best.
>> Sorry I missed early versions of this.  There is no reason
>> that I know of to involve configure in this.
> As a developer at least I typically run configure once (or infrequently)
> and then run make a lot. Having to remember to put stuff on the make
> command line defeats that. In some ways this is part of the reason for
> using autoconf.
>
> I don't think splitting things between .config and autoconf is a
> particularly brilliant way to do things, at least for tools related
> stuff.

I also think that is better add it on configure, probably today I'll do, 
test and post the v7 following your previous advices.

>
>>    The following
>> works just fine (Just the makefile change and a changed
>> commit message):
>>
>>
>>
>>   From 847b9dee4dea17c86f6ec402e5fcff7d515d1767 Mon Sep 17 00:00:00 2001
>> From: Fabio Fantoni <fabio.fantoni@m2r.biz>
>> Date: Tue, 6 May 2014 16:30:50 +0200
>> Subject: [PATCH] tools: Pass arbitrary build options to qemu upstream.
>>
>> Usage examples:
>>
>>     CONFIG_QEMUU_EXTRA_ARGS="--enable-spice --enable-usb-redir" make tools
>>
>> or
>>
>>     make tools CONFIG_QEMUU_EXTRA_ARGS="--enable-spice --enable-usb-redir"
>>
>> or
>>
>>     echo CONFIG_QEMUU_EXTRA_ARGS="--enable-spice --enable-usb-redir" >>.config
>>     make tools
>>
>> or
>>
>>     export CONFIG_QEMUU_EXTRA_ARGS="--enable-spice --enable-usb-redir"
>>     make tools
>>
>> Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
>> ---
>>    tools/Makefile | 1 +
>>    1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/Makefile b/tools/Makefile
>> index 3675515..992fe3e 100644
>> --- a/tools/Makefile
>> +++ b/tools/Makefile
>> @@ -203,6 +203,7 @@ subdir-all-qemu-xen-dir: qemu-xen-dir-find
>>                   --disable-docs \
>>                   --disable-guest-agent \
>>                   --python=$(PYTHON) \
>> +               $(CONFIG_QEMUU_EXTRA_ARGS) \
>>                   $(IOEMU_CONFIGURE_CROSS); \
>>           $(MAKE) all
>>
>