pygrub fails with NameError: name 'fs' is not defined

["Sven Köhler" <sven.koehler@gmail.com>]

Hi,

I get this rather puzzling error:

Traceback (most recent call last):
  File "/usr/lib64/xen/bin/pygrub", line 885, in <module>
    if not fs:
NameError: name 'fs' is not defined

This is pygrub from xen-tools 4.4.0.
I found a rather old thread about the same issue:
http://old-list-archives.xenproject.org/xen-devel/2011-01/msg02076.html

But it seems like the problem has already been fixed and indeed there
are some similarities, namely that /dev/md4 (which is xvda1 in the domU)
does not contain a partition table.

Now the issue here seems to be that boot sector of /dev/md4 is a little
screwed up. Namely, fdisk -l /dev/md4 seems to report an empty partition
table. This is not the case for other domU I have. Maybe, the
boot-sector is to MBR like after running grub-install /dev/xvda1 inside
the domU. Or maybe after trying LILO. I don't know.

Anyhow, the error above seems like a programming mistake (variable fs is
not defined? Sorry, I don't know python). So I'm hereby reporting it.

Maybe I will switch to a partitioned /dev/xvda instead of providing
/dev/xvda1 directly to the domU.

Has there been any improvement regarding pygrub for the case of
unpartitioned disks? It seems like it would be easy to support that case
more reliably if xl would pass some more information to pygrub. However,
in the thread from the archive, Ian made it sound like that would be
complicated. (In fact, if pygrub would know that the device name was
xvda1 and not xvda it could stop looking for a partition table).


Regards,
  Sven