Re: [PATCH v7 07/10] xen/common: move the memory_mapping DOMCTL hypercall to common code

[Arianna Avanzini <avanzini.arianna@gmail.com>]

On 05/06/2014 06:54 PM, Julien Grall wrote:
> Hi Arianna,
> 
> On 05/05/2014 04:54 PM, Arianna Avanzini wrote:
>> +            ret = iomem_permit_access(d, mfn, mfn_end);
>> +            if ( !ret )
>> +            {
>> +                ret = map_mmio_regions(d, gfn, nr_mfns, _mfn(mfn));
> 
> The code of map_mmio_regions differs between x86 on ARM.
> 
> On the former architecture, if Xen fails to map a page, it will unmap
> all the previous page. It's not the case on ARM.
> 

The map_mmio_regions() implementation for x86 (factored out from the
x86-specific code in patch 0006) includes also unmapping the pages in the case
of an error (even if I just realized that I made a mistake there by still using
the end gfn instead of the number of gfns). The ARM implementation is still the
original one, calling apply_p2m_changes().


> Regards,
> 


-- 
/*
 * Arianna Avanzini
 * avanzini.arianna@gmail.com
 * 73628@studenti.unimore.it
 */