xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Valentin Priescu <vali.priescu@gmail.com>
Cc: xen-devel <xen-devel@lists.xensource.com>,
	Matt Wilson <msw@amazon.com>,
	Valentin Priescu <priescuv@amazon.com>
Subject: Re: [PATCH] xen-blkback: defer freeing blkif to avoid blocking xenwatch
Date: Mon, 12 May 2014 11:43:56 +0100	[thread overview]
Message-ID: <5370A5EC.1010808@citrix.com> (raw)
In-Reply-To: <CANYcwK5_F_oM=QCHYcZgDMufO_v8G5smgzCSu7aq0tuE7URUGg@mail.gmail.com>

On 12/05/14 11:41, Valentin Priescu wrote:
> On Mon, May 12, 2014 at 11:39 AM, David Vrabel <david.vrabel@citrix.com> wrote:
>> If xen_blkif_disconnect() returns -EBUSY, nothing will trigger the
>> reconnect.
>>
> 
> Yeah, I should do something like:
> err = xen_blkif_disconnect(be->blkif);
> if (err) {
>     xenbus_dev_fatal(dev, err, "disconnecting %s",
>             dev->otherend);

I think that's ok, but the error message should be "pending I/O".  You
don't need to include the name of the otherend in the error message.

David

  reply	other threads:[~2014-05-12 10:43 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-09 23:34 [PATCH] xen-blkback: defer freeing blkif to avoid blocking xenwatch Valentin Priescu
2014-05-09 23:56 ` Matt Wilson
2014-05-12  6:42   ` Vasiliy Tolstov
2014-05-12  8:59     ` Valentin Priescu
2014-05-12  9:12       ` Alexey
2014-05-12 10:50         ` Valentin Priescu
2014-05-12  9:39 ` David Vrabel
2014-05-12 10:41   ` Valentin Priescu
2014-05-12 10:43     ` David Vrabel [this message]
2014-05-12 10:47       ` Valentin Priescu
2014-05-12 16:40 ` Boris Ostrovsky
2014-05-12 17:04   ` Valentin Priescu
2014-05-12 17:50     ` Boris Ostrovsky
2014-05-12 19:25 ` [PATCH v2] " Valentin Priescu
2014-05-13  9:32   ` David Vrabel
2014-05-13 17:00     ` Vasiliy Tolstov
2014-05-13 17:32       ` Valentin Priescu
2014-05-13 17:39         ` Vasiliy Tolstov
2014-05-16  8:37     ` Valentin Priescu
2014-06-02 16:20     ` Matt Wilson
2014-05-20 20:28   ` [PATCH v3] " Valentin Priescu
2014-05-22  9:11     ` Vasiliy Tolstov
2014-05-22 10:16       ` Valentin Priescu
2014-06-03  8:07         ` Vasiliy Tolstov
2014-06-03  9:59           ` Valentin Priescu
2014-06-02 16:13     ` Valentin Priescu
2014-06-02 16:56       ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5370A5EC.1010808@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=msw@amazon.com \
    --cc=priescuv@amazon.com \
    --cc=vali.priescu@gmail.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).