From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH] xen-blkback: defer freeing blkif to avoid
 blocking xenwatch
Date: Mon, 12 May 2014 11:43:56 +0100
Message-ID: <5370A5EC.1010808@citrix.com>
References: <1399678479-14758-1-git-send-email-vali.priescu@gmail.com>	<537096D5.4090809@citrix.com>
	<CANYcwK5_F_oM=QCHYcZgDMufO_v8G5smgzCSu7aq0tuE7URUGg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CANYcwK5_F_oM=QCHYcZgDMufO_v8G5smgzCSu7aq0tuE7URUGg@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Valentin Priescu <vali.priescu@gmail.com>
Cc: xen-devel <xen-devel@lists.xensource.com>, Matt Wilson <msw@amazon.com>, Valentin Priescu <priescuv@amazon.com>
List-Id: xen-devel@lists.xenproject.org

On 12/05/14 11:41, Valentin Priescu wrote:
> On Mon, May 12, 2014 at 11:39 AM, David Vrabel <david.vrabel@citrix.com> wrote:
>> If xen_blkif_disconnect() returns -EBUSY, nothing will trigger the
>> reconnect.
>>
> 
> Yeah, I should do something like:
> err = xen_blkif_disconnect(be->blkif);
> if (err) {
>     xenbus_dev_fatal(dev, err, "disconnecting %s",
>             dev->otherend);

I think that's ok, but the error message should be "pending I/O".  You
don't need to include the name of the otherend in the error message.

David