From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [RFC v3 3/6] xen/arm: Add save/restore support for
	ARM arch timer
Date: Mon, 12 May 2014 12:42:35 +0100
Message-ID: <5370B3AB.2070607@linaro.org>
References: <1399583908-21755-1-git-send-email-w1.huang@samsung.com>	
	<1399583908-21755-4-git-send-email-w1.huang@samsung.com>	
	<536F3BCA.2060407@linaro.org>
	<1399883711.561.72.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1399883711.561.72.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Wei Huang <w1.huang@samsung.com>, keir@xen.org, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, tim@xen.org, jaeyong.yoo@samsung.com, xen-devel@lists.xen.org, jbeulich@suse.com, ian.jackson@eu.citrix.com, yjhyun.yoo@samsung.com
List-Id: xen-devel@lists.xenproject.org

On 05/12/2014 09:35 AM, Ian Campbell wrote:
> On Sun, 2014-05-11 at 09:58 +0100, Julien Grall wrote:
>> Hi Wei,
>>
>> Thank you for the patch.
>>
>> On 08/05/14 22:18, Wei Huang wrote:
>>> +    switch ( ctxt.type )
>>> +    {
>>> +    case ARM_TIMER_TYPE_PHYS:
>>> +        t = &v->arch.phys_timer;
>>> +        d->arch.phys_timer_base.offset = ctxt.vtb_offset;
>>> +        break;
>>> +    case ARM_TIMER_TYPE_VIRT:
>>> +        t = &v->arch.virt_timer;
>>> +        d->arch.virt_timer_base.offset = ctxt.vtb_offset;
>>
>> It seems you forgot to address some of my comments on the timer 
>> save/restore.
>>
>> Saving {virt,phys}_timer_base.offset per VCPU rather than per-domain 
>> seems a waste of space and confusing.
> 
> Is it 100% inconceivable that two vcpus might some day have different
> timers?

By timers, did you mean did different boot offset?

AFAIU, the timer counter (CNTP) is common to every {p,v{CPUs and
contains the number of ticks from the start time.

If some days we want to have two vcpus with different offfset, then we
can extend the format.

Regards,

-- 
Julien Grall