From: Jacek Konieczny <jajcus@jajcus.net>
To: Ian Campbell <Ian.Campbell@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "Stefano Stabellini" <stefano.stabellini@eu.citrix.com>,
"Luis R. Rodriguez" <mcgrof@suse.com>,
"Jan Rękorajski" <baggins@pld-linux.org>,
"M A Young" <m.a.young@durham.ac.uk>,
xen-devel@lists.xenproject.org,
"Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Subject: Re: [PATCH v4 01/15] xenstore: add support for a retry open limit on xenstored
Date: Mon, 12 May 2014 16:40:31 +0200 [thread overview]
Message-ID: <5370DD5F.1000406@jajcus.net> (raw)
In-Reply-To: <1399904307.4428.26.camel@kazak.uk.xensource.com>
On 05/12/14 16:18, Ian Campbell wrote:
> On Mon, 2014-05-12 at 14:50 +0100, Ian Jackson wrote:
>> Luis R. Rodriguez writes ("[PATCH v4 01/15] xenstore: add support for a retry open limit on xenstored"):
>>> This adds support for a customizable retry limit on trying to open
>>> the xenstored unix domain socket, each retry is separated by 1 second.
>>> This should allow us to simplify both our LSB init scripts. For systemd
>>> we'll use socket activation.
>>
>> I'm afraid I fundamentally disagree with this timeout/polling based
>> approach.
>
> As for the retry -- I suppose xenstored forks before it is really ready?
I guess this should be fixed in xenstored instead of hacking
work-arounds in the client. When daemon start succeeds then the socket
should be available and working. If it failed, no retry will help. If
the daemon is still starting although the start command exited – than
this sounds like a bug.
Jacek
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-05-12 14:40 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 1:11 [PATCH v4 00/15] xen: add systemd support Luis R. Rodriguez
2014-04-30 1:11 ` [PATCH v4 01/15] xenstore: add support for a retry open limit on xenstored Luis R. Rodriguez
2014-05-07 15:03 ` Ian Campbell
2014-05-12 13:50 ` Ian Jackson
2014-05-12 14:18 ` Ian Campbell
2014-05-12 14:40 ` Jacek Konieczny [this message]
2014-05-12 15:37 ` Ian Jackson
2014-05-12 18:59 ` Luis R. Rodriguez
2014-05-13 21:33 ` Luis R. Rodriguez
2014-04-30 1:11 ` [PATCH v4 02/15] xencommons: use the retry limit instead of implementing our own timeout Luis R. Rodriguez
2014-04-30 9:33 ` Andrew Cooper
2014-04-30 16:36 ` Luis R. Rodriguez
2014-05-07 15:05 ` Ian Campbell
2014-04-30 1:11 ` [PATCH v4 03/15] xenstored: enable usage of config.h on both xenstored and oxenstored Luis R. Rodriguez
2014-05-07 15:06 ` Ian Campbell
2014-04-30 1:11 ` [PATCH v4 04/15] cxenstored: add support for systemd active sockets Luis R. Rodriguez
2014-05-07 15:18 ` Ian Campbell
2014-05-07 15:46 ` Ian Campbell
2014-05-13 22:17 ` Luis R. Rodriguez
2014-05-14 8:44 ` Ian Campbell
2014-05-15 1:50 ` Luis R. Rodriguez
2014-04-30 1:11 ` [PATCH v4 05/15] oxenstored: " Luis R. Rodriguez
2014-04-30 8:35 ` Dave Scott
2014-04-30 17:30 ` Luis R. Rodriguez
2014-05-01 10:21 ` Dave Scott
2014-04-30 9:27 ` Anil Madhavapeddy
2014-04-30 17:35 ` Luis R. Rodriguez
2014-05-01 9:16 ` Anil Madhavapeddy
2014-05-07 15:20 ` Ian Campbell
2014-05-12 19:09 ` Luis R. Rodriguez
2014-05-12 13:57 ` Ian Jackson
2014-05-12 18:11 ` Luis R. Rodriguez
2014-05-13 8:53 ` Ian Campbell
2014-04-30 1:11 ` [PATCH v4 06/15] tools/xendomains: make xl the default Luis R. Rodriguez
2014-04-30 7:02 ` Olaf Hering
2014-04-30 17:43 ` Luis R. Rodriguez
2014-05-07 15:21 ` Ian Campbell
2014-04-30 1:12 ` [PATCH v4 07/15] tools/xendomains: do space cleanups Luis R. Rodriguez
2014-04-30 1:12 ` [PATCH v4 08/15] tools/xendomains: move to libexec and use a smaller init helper Luis R. Rodriguez
2014-05-07 15:24 ` Ian Campbell
2014-05-13 22:21 ` Luis R. Rodriguez
2014-04-30 1:12 ` [PATCH v4 09/15] autoconf: xen: force a refresh with autoconf Luis R. Rodriguez
2014-05-07 15:25 ` Ian Campbell
2014-05-07 16:12 ` Roger Pau Monné
2014-05-07 16:21 ` Ian Campbell
2014-05-07 16:44 ` Roger Pau Monné
2014-05-07 18:28 ` Luis R. Rodriguez
2014-05-12 14:00 ` Ian Jackson
2014-05-12 18:14 ` Luis R. Rodriguez
2014-04-30 1:12 ` [PATCH v4 10/15] autoconf: update m4/pkg.m4 Luis R. Rodriguez
2014-05-07 15:28 ` Ian Campbell
2014-05-13 22:32 ` Luis R. Rodriguez
2014-05-07 16:17 ` Roger Pau Monné
2014-04-30 1:12 ` [PATCH v4 11/15] autoconf: xen: move standard variables to a generic place Luis R. Rodriguez
2014-04-30 6:52 ` Jan Beulich
[not found] ` <5360B9CB020000780000D9BB@suse.com>
2014-04-30 17:53 ` Luis R. Rodriguez
2014-05-02 8:12 ` Jan Beulich
2014-05-13 23:03 ` Luis R. Rodriguez
2014-04-30 1:12 ` [PATCH v4 12/15] autoconf: xen: peg the xenstored preference onto the top level config Luis R. Rodriguez
2014-05-07 15:32 ` Ian Campbell
2014-05-13 23:05 ` Luis R. Rodriguez
2014-04-30 1:12 ` [PATCH v4 13/15] systemd: add xen systemd service and module files Luis R. Rodriguez
2014-05-07 15:46 ` Ian Campbell
2014-05-12 18:22 ` Luis R. Rodriguez
2014-05-13 23:28 ` Luis R. Rodriguez
2014-05-12 14:11 ` Ian Jackson
2014-05-12 14:32 ` Jacek Konieczny
2014-05-12 15:36 ` Ian Jackson
2014-05-12 18:55 ` Luis R. Rodriguez
2014-05-12 18:46 ` Luis R. Rodriguez
2014-05-13 8:57 ` Ian Campbell
2014-04-30 1:12 ` [PATCH v4 14/15] autoconf: xen: add systemd support into the build system Luis R. Rodriguez
2014-05-07 16:40 ` Roger Pau Monné
2014-05-15 1:58 ` Luis R. Rodriguez
2014-05-15 9:02 ` Ian Campbell
2014-04-30 1:12 ` [PATCH v4 15/15] autoconf: xen: trigger an update with autogen.sh Luis R. Rodriguez
2014-05-07 15:47 ` Ian Campbell
2014-05-07 18:34 ` Luis R. Rodriguez
2014-05-08 8:42 ` Ian Campbell
2014-04-30 1:15 ` [PATCH v4 00/15] xen: add systemd support Luis R. Rodriguez
2014-05-07 15:18 ` Ian Campbell
2014-05-08 11:28 ` Anthony PERARD
2014-05-15 2:12 ` Luis R. Rodriguez
2014-05-15 6:14 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5370DD5F.1000406@jajcus.net \
--to=jajcus@jajcus.net \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=baggins@pld-linux.org \
--cc=m.a.young@durham.ac.uk \
--cc=mcgrof@do-not-panic.com \
--cc=mcgrof@suse.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).