From: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>,
Jun Nakajima <jun.nakajima@intel.com>,
Eddie Dong <eddie.dong@intel.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Ian Campbell <Ian.Campbell@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@citrix.com>,
suravee.suthikulpanit@amd.com,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH] switch hypercall restart indication from -EAGAIN to -ERESTART
Date: Mon, 12 May 2014 10:16:12 -0500 [thread overview]
Message-ID: <5370E5BC.80404@amd.com> (raw)
In-Reply-To: <5370EDB40200007800011718@mail.emea.novell.com>
On 5/12/2014 8:50 AM, Jan Beulich wrote:
> -EAGAIN being a return value we want to return to the actual caller in
> a couple of cases makes this unsuitable for restart indication, and x86
> already developed two cases where -EAGAIN could not be returned as
> intended due to this (which is being fixed here at once).
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
>
> --- a/xen/arch/x86/hvm/svm/svm.c
> +++ b/xen/arch/x86/hvm/svm/svm.c
> @@ -1827,7 +1827,7 @@ static int svm_msr_write_intercept(unsig
>
> switch ( wrmsr_hypervisor_regs(msr, msr_content) )
> {
> - case -EAGAIN:
> + case -ERESTART:
> result = X86EMUL_RETRY;
> break;
> case 0:
>
Acked-by: Aravind Gopalakrishnan<Aravind.Gopalakrishnan@amd.com>
next prev parent reply other threads:[~2014-05-12 15:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 13:50 [PATCH] switch hypercall restart indication from -EAGAIN to -ERESTART Jan Beulich
2014-05-12 14:13 ` Ian Campbell
2014-05-12 14:24 ` Jan Beulich
2014-05-12 15:16 ` Aravind Gopalakrishnan [this message]
2014-05-15 11:24 ` Tim Deegan
2014-05-15 11:56 ` Jan Beulich
2014-05-15 12:01 ` Tim Deegan
2014-05-15 12:07 ` Jan Beulich
2014-05-15 12:10 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5370E5BC.80404@amd.com \
--to=aravind.gopalakrishnan@amd.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=eddie.dong@intel.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=stefano.stabellini@citrix.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).