From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aravind Gopalakrishnan Subject: Re: [PATCH] switch hypercall restart indication from -EAGAIN to -ERESTART Date: Mon, 12 May 2014 10:16:12 -0500 Message-ID: <5370E5BC.80404@amd.com> References: <5370EDB40200007800011718@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Wjrxn-0006Wm-JA for xen-devel@lists.xenproject.org; Mon, 12 May 2014 15:16:23 +0000 In-Reply-To: <5370EDB40200007800011718@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel Cc: Kevin Tian , Keir Fraser , Jun Nakajima , Eddie Dong , Ian Jackson , Tim Deegan , Ian Campbell , Stefano Stabellini , suravee.suthikulpanit@amd.com, Boris Ostrovsky List-Id: xen-devel@lists.xenproject.org On 5/12/2014 8:50 AM, Jan Beulich wrote: > -EAGAIN being a return value we want to return to the actual caller in > a couple of cases makes this unsuitable for restart indication, and x86 > already developed two cases where -EAGAIN could not be returned as > intended due to this (which is being fixed here at once). > > Signed-off-by: Jan Beulich > > > --- a/xen/arch/x86/hvm/svm/svm.c > +++ b/xen/arch/x86/hvm/svm/svm.c > @@ -1827,7 +1827,7 @@ static int svm_msr_write_intercept(unsig > > switch ( wrmsr_hypervisor_regs(msr, msr_content) ) > { > - case -EAGAIN: > + case -ERESTART: > result = X86EMUL_RETRY; > break; > case 0: > Acked-by: Aravind Gopalakrishnan