From: "Jan Beulich" <JBeulich@suse.com>
To: Malcolm Crossley <malcolm.crossley@citrix.com>
Cc: Ian.Jackson@citrix.com, Paul.Durrant@citrix.com,
Ian.Campbell@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v3] hw/passthrough: Prevent QEMU from mapping PCI option ROM at address 0
Date: Mon, 12 May 2014 15:53:37 +0100 [thread overview]
Message-ID: <5370FC910200007800011815@mail.emea.novell.com> (raw)
In-Reply-To: <1399905420-4782-1-git-send-email-malcolm.crossley@citrix.com>
>>> On 12.05.14 at 16:37, <malcolm.crossley@citrix.com> wrote:
> The PCI option ROM BAR uses the LSB to indicate if the BAR is enabled.
> The AMD graphics driver sets the address bit's of the BAR to 0 but leaves the
> LSB set to 1. Whilst this is not good practice, QEMU should be ignoring the
> non address parts of the BAR.
>
> This patch adds masking of the bits 0-10 (4k page) parts of the BAR
> before comparing the address to 0.
Sorry, but to avoid confusing (future) readers - this is 2k units, not
4k pages.
> Signed-off-by: Malcolm Crossley <malcolm.crossley@citrix.com>
With the description corrected:
Reviewed-by: Jan Beulich <jbeulich@suse.com>
next prev parent reply other threads:[~2014-05-12 14:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 14:37 [PATCH v3] hw/passthrough: Prevent QEMU from mapping PCI option ROM at address 0 Malcolm Crossley
2014-05-12 14:53 ` Jan Beulich [this message]
2014-05-12 15:32 ` Malcolm Crossley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5370FC910200007800011815@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@citrix.com \
--cc=Paul.Durrant@citrix.com \
--cc=malcolm.crossley@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).