From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [RFC v2 1/6] xen/arm: Save and restore support with
 hvm context hypercalls
Date: Tue, 13 May 2014 17:37:49 +0100
Message-ID: <53724A5D.2040000@linaro.org>
References: <w1.huang@samsung.com>
	<1397595918-30419-1-git-send-email-w1.huang@samsung.com>
	<1397595918-30419-2-git-send-email-w1.huang@samsung.com>
	<534FEDFD.7030202@linaro.org>
	<1399886168.561.95.camel@kazak.uk.xensource.com>
	<5370B8DD.6000600@linaro.org> <53723ACC.8040402@samsung.com>
	<53723D48.2050800@linaro.org> <537245D0.2010908@samsung.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <537245D0.2010908@samsung.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Huang <w1.huang@samsung.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 05/13/2014 05:18 PM, Wei Huang wrote:
> Given the comments from you and Andrew, I will revise the context struct
> to the following format. With this, we can get rid of most problems
> (switch/case/...).

With this solution, you will duplicate code to save/restore the timer.

> struct hvm_arm_timer
> {
>     /* phys_timer */
>     uint64_t phys_vtb_offset;
>     uint64_t phys_cval;
>     uint32_t phys_ctl;

If I'm not mistaken, you need a 32 bit padding here ...

> 
>     /* virt_timer */
>     uint64_t virt_vtb_offset;
>     uint64_t virt_cval;
>     uint32_t virt_ctl;

... and here

Regards,

-- 
Julien Grall