From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC v3 5/6] xen/arm: Add log_dirty support for ARM Date: Wed, 14 May 2014 13:20:31 +0100 Message-ID: <53735F8F.2040200@linaro.org> References: <1399583908-21755-1-git-send-email-w1.huang@samsung.com> <1399583908-21755-6-git-send-email-w1.huang@samsung.com> <536F9707.4060807@linaro.org> <1400068635.29366.59.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1400068635.29366.59.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Wei Huang , keir@xen.org, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, tim@xen.org, jaeyong.yoo@samsung.com, xen-devel@lists.xen.org, jbeulich@suse.com, ian.jackson@eu.citrix.com, yjhyun.yoo@samsung.com List-Id: xen-devel@lists.xenproject.org On 05/14/2014 12:57 PM, Ian Campbell wrote: >>> @@ -341,6 +343,27 @@ static inline void put_page_and_type(struct page_info *page) >>> put_page(page); >>> } >>> >>> +enum mg { mg_clear, mg_ro, mg_rw, mg_rx }; >> >> Please describe this enum. Also mg is too generic. > > This is just code motion. This enum has been moved in a header which is included everywhere. Keeping the name "mg" without any description is confusion. Developper can misuse this enum. >>> @@ -41,6 +42,7 @@ typedef enum { >>> p2m_invalid = 0, /* Nothing mapped here */ >>> p2m_ram_rw, /* Normal read/write guest RAM */ >>> p2m_ram_ro, /* Read-only; writes are silently dropped */ >>> + p2m_ram_logdirty, /* Read-only: special mode for log dirty */ >> >> You should at the new type at the end of the enum. > > Why? Keeping p2m_ram_* together doesn't seem wrong to me. My mistake, I though we store the P2M during the migration. Regards, -- Julien Grall