From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC v3 4/6] xen/arm: Add save/restore support for guest core registers Date: Wed, 14 May 2014 13:23:41 +0100 Message-ID: <5373604D.9020505@linaro.org> References: <1399583908-21755-1-git-send-email-w1.huang@samsung.com> <1399583908-21755-5-git-send-email-w1.huang@samsung.com> <536F3D8A.9010605@linaro.org> <1400066167.29366.32.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1400066167.29366.32.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Wei Huang , keir@xen.org, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, tim@xen.org, jaeyong.yoo@samsung.com, xen-devel@lists.xen.org, jbeulich@suse.com, ian.jackson@eu.citrix.com, yjhyun.yoo@samsung.com List-Id: xen-devel@lists.xenproject.org On 05/14/2014 12:16 PM, Ian Campbell wrote: > On Sun, 2014-05-11 at 10:06 +0100, Julien Grall wrote: >> Hi Wei, >> >> Thank you for the patch. >> >> On 08/05/14 22:18, Wei Huang wrote: >>> This patch implements a save/resore support for ARM guest core >>> registers. >> >> >> The commit 893256f "xen/arm: Correctly save/restore CNTKCTL_EL1" >> save/restore a new register during the context switch. >> >> I think you forgot to add it in this patch. > > I think it would belong in the previous patch with the timer state. If Wei plans to use his new structure (see [1]), I'm fine with save/restore on the previous patch. Otherwise it seems stupid to save twice the same value. Regards, [1] http://lists.xen.org/archives/html/xen-devel/2014-05/msg01642.html -- Julien Grall