From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v5 01/14] xen/arm: Introduce flush_tlb_domain Date: Wed, 14 May 2014 14:29:32 +0100 Message-ID: <53736FBC.6090002@linaro.org> References: <1399996230-18201-1-git-send-email-julien.grall@linaro.org> <1399996230-18201-2-git-send-email-julien.grall@linaro.org> <1400074085.29366.118.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WkZFY-0006lp-Ry for xen-devel@lists.xenproject.org; Wed, 14 May 2014 13:29:37 +0000 Received: by mail-ee0-f53.google.com with SMTP id c13so1366399eek.26 for ; Wed, 14 May 2014 06:29:35 -0700 (PDT) In-Reply-To: <1400074085.29366.118.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com, tim@xen.org List-Id: xen-devel@lists.xenproject.org On 05/14/2014 02:28 PM, Ian Campbell wrote: > On Tue, 2014-05-13 at 16:50 +0100, Julien Grall wrote: >> The pattern p2m_load_VTTBR(d) -> flush_tlb -> p2m_load_VTTBR(current->domain) >> is used in few places. >> >> Replace this usage by flush_tlb_domain which will take care of this pattern. >> This will help to the lisibility of apply_p2m_changes which begin to be big. > > "lisibility"? Did you mean to type "visibility"? I think the word you > really wanted was "readability". I meant readability. It was a quick & bad translation from French. >> diff --git a/xen/include/asm-arm/flushtlb.h b/xen/include/asm-arm/flushtlb.h >> index 329fbb4..5722c67 100644 >> --- a/xen/include/asm-arm/flushtlb.h >> +++ b/xen/include/asm-arm/flushtlb.h >> @@ -25,6 +25,9 @@ do { \ >> /* Flush specified CPUs' TLBs */ >> void flush_tlb_mask(const cpumask_t *mask); >> >> +/* Flush CPU's TLBs for the speficied domain */ > > "Specified" > > Other than those two nits: > Acked-by: Ian Campbell Thanks! -- Julien Grall