From: "Jan Beulich" <JBeulich@suse.com>
To: Juergen Gross <juergen.gross@ts.fujitsu.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] cpupools: retry cpupool-destroy if domain in cpupool is dying
Date: Wed, 14 May 2014 13:28:32 +0100 [thread overview]
Message-ID: <53737D900200007800012238@mail.emea.novell.com> (raw)
In-Reply-To: <537346DB.9070009@ts.fujitsu.com>
>>> On 14.05.14 at 12:35, <juergen.gross@ts.fujitsu.com> wrote:
> On 14.05.2014 12:15, Jan Beulich wrote:
>> What prevents cpupool_rm_domain() getting moved from
>> complete_domain_destroy() to domain_destroy(), before the
>> domain gets taken off the list? I actually assume that there are
>> more things here that may not really need deferring until the
>> last possible moment...
>
> sched_destroy_vcpu() and sched_destroy_domain() have to happen before
> cpupool_rm_domain(). This could be avoided if the domain would be moved to
> cpupool0 in domain_destroy().
>
> Hmm, doesn't sound too bad. This would be just symmetrical to domain
> creation. What do you think?
I'm always in favor of symmetry, where possible and suitable. So
unless George objects or sees problems with this, why don't you
give this a try?
Jan
next prev parent reply other threads:[~2014-05-14 12:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 11:49 [PATCH] cpupools: retry cpupool-destroy if domain in cpupool is dying Juergen Gross
2014-05-14 9:16 ` George Dunlap
2014-05-14 9:48 ` George Dunlap
2014-05-14 9:50 ` George Dunlap
2014-05-14 12:28 ` Tim Deegan
2014-05-14 9:56 ` Juergen Gross
2014-05-14 10:15 ` Jan Beulich
2014-05-14 10:19 ` George Dunlap
2014-05-14 10:35 ` Juergen Gross
2014-05-14 12:28 ` Jan Beulich [this message]
2014-05-14 13:05 ` Juergen Gross
2014-05-14 13:13 ` Jan Beulich
2014-05-14 13:22 ` Juergen Gross
-- strict thread matches above, loose matches on Subject: below --
2014-05-07 7:52 Juergen Gross
2014-05-07 13:10 ` George Dunlap
2014-05-07 13:23 ` Juergen Gross
2014-05-08 15:10 ` George Dunlap
2014-05-09 5:01 ` Juergen Gross
2014-05-12 10:50 ` George Dunlap
2014-05-12 10:54 ` George Dunlap
2014-05-12 11:31 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53737D900200007800012238@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=juergen.gross@ts.fujitsu.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).