From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= Subject: Re: [PATCH 1/5] hotplug/linux: Fix the vif script to handle_iptable for tap interfaces Date: Wed, 14 May 2014 13:08:34 -0400 Message-ID: <5373A312.2030900@citrix.com> References: <1400081005-23895-1-git-send-email-s.munaut@whatever-company.com> <1400081005-23895-2-git-send-email-s.munaut@whatever-company.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Wkcfm-0008LK-Ib for xen-devel@lists.xenproject.org; Wed, 14 May 2014 17:08:54 +0000 In-Reply-To: <1400081005-23895-2-git-send-email-s.munaut@whatever-company.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Sylvain Munaut , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On 14/05/14 11:23, Sylvain Munaut wrote: > The TAP interfaces need the same iptables rules as the VIF, without it, > traffic will not be forwarded to/from them is the default FORWARD policy > is DROP/REJECT > > Signed-off-by: Sylvain Munaut > --- > tools/hotplug/Linux/vif-bridge | 2 +- > tools/hotplug/Linux/vif-common.sh | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/hotplug/Linux/vif-bridge b/tools/hotplug/Linux/vif-bridge > index b7dcbd6..87279df 100644 > --- a/tools/hotplug/Linux/vif-bridge > +++ b/tools/hotplug/Linux/vif-bridge > @@ -97,7 +97,7 @@ case "$command" in > ;; > esac > > -if [ "$type_if" = vif ]; then > +if [ "$type_if" = vif -o "$type_if" = tap ]; then type_if can only be "vif" or "tap" so AFAICT you can drop the if altogether, the rest looks fine. Roger.