From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH RFC 1/9] x86/traps: Names for system
	descriptor types
Date: Thu, 15 May 2014 11:26:37 +0100
Message-ID: <5374965D.9050500@citrix.com>
References: <1400147299-31772-1-git-send-email-andrew.cooper3@citrix.com>
	<1400147299-31772-2-git-send-email-andrew.cooper3@citrix.com>
	<5374AE3E0200007800012862@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5374AE3E0200007800012862@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 15/05/14 11:08, Jan Beulich wrote:
>>>> On 15.05.14 at 11:48, <andrew.cooper3@citrix.com> wrote:
>> Avoids some particularly obscure magic numbers
> Very desirable. A small comment below.
>
>> --- a/xen/include/asm-x86/desc.h
>> +++ b/xen/include/asm-x86/desc.h
>> @@ -98,6 +98,14 @@
>>  
>>  #ifndef __ASSEMBLY__
>>  
>> +/* System Descriptor types in the GDT */
>> +#define DESC_TYPE_ldt       (2)
>> +#define DESC_TYPE_tss_avail (9)
>> +#define DESC_TYPE_tss_busy  (11)
>> +#define DESC_TYPE_call_gate (12)
>> +#define DESC_TYPE_irq_gate  (14)
>> +#define DESC_TYPE_trap_gate (15)
> Either you say GDT/IDT in the comment, or you separate the GDT
> ones from the IDT ones.

Will say GDT/IDT.  These type numbers generic across both tables.

>
> Plus the comment is missing a stop.
>
> And finally I don't think the parentheses are warranted here.
>
> Jan
>

Ok.  Any views on SYS_DESC_xxx ?  I think I prefer it slightly, and
would allow removal of the _gate suffix, which would not be useful in
context.

~Andrew