From: "Jan Beulich" <JBeulich@suse.com>
To: Tim Deegan <tim@xen.org>
Cc: Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>,
Jun Nakajima <jun.nakajima@intel.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Eddie Dong <eddie.dong@intel.com>,
Ian Campbell <Ian.Campbell@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@citrix.com>,
suravee.suthikulpanit@amd.com,
xen-devel <xen-devel@lists.xenproject.org>,
Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH] switch hypercall restart indication from -EAGAIN to -ERESTART
Date: Thu, 15 May 2014 12:56:15 +0100 [thread overview]
Message-ID: <5374C77F02000078000129B2@mail.emea.novell.com> (raw)
In-Reply-To: <20140515112409.GD40104@deinos.phlegethon.org>
>>> On 15.05.14 at 13:24, <tim@xen.org> wrote:
> Some of the paths are a bit complex now, e.g. a preemption
> point being reported as EINTR by __put_page_type(), translated to
> ERESTART by relinquish_memory(), then to EAGAIN by domain_kill().
That second conversion I expect to go away anyway - we shouldn't
really rely on the tools to do the hypercall re-invocations. I've got
this as part of another domctl/XSA-77 follow-up patch already.
> Are there cases where we want to return EINTR to the guest, or could
> we maybe use it everywhere and drop ERESTART?
No, we need two distinct error codes on these paths. For now we
never need to return -EINTR to the guest (and for now I also can't
see when/why we would), but we'd have to convert these too
should the need arise.
Jan
next prev parent reply other threads:[~2014-05-15 11:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 13:50 [PATCH] switch hypercall restart indication from -EAGAIN to -ERESTART Jan Beulich
2014-05-12 14:13 ` Ian Campbell
2014-05-12 14:24 ` Jan Beulich
2014-05-12 15:16 ` Aravind Gopalakrishnan
2014-05-15 11:24 ` Tim Deegan
2014-05-15 11:56 ` Jan Beulich [this message]
2014-05-15 12:01 ` Tim Deegan
2014-05-15 12:07 ` Jan Beulich
2014-05-15 12:10 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5374C77F02000078000129B2@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=aravind.gopalakrishnan@amd.com \
--cc=boris.ostrovsky@oracle.com \
--cc=eddie.dong@intel.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=stefano.stabellini@citrix.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).