From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH] switch hypercall restart indication from -EAGAIN to -ERESTART Date: Thu, 15 May 2014 13:07:56 +0100 Message-ID: <5374CA3C02000078000129FF@mail.emea.novell.com> References: <5370EDB40200007800011718@mail.emea.novell.com> <20140515112409.GD40104@deinos.phlegethon.org> <5374C77F02000078000129B2@mail.emea.novell.com> <20140515120116.GA39957@deinos.phlegethon.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WkuS7-0001hJ-HR for xen-devel@lists.xenproject.org; Thu, 15 May 2014 12:07:59 +0000 In-Reply-To: <20140515120116.GA39957@deinos.phlegethon.org> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tim Deegan Cc: Kevin Tian , Keir Fraser , Jun Nakajima , Ian Jackson , Eddie Dong , Ian Campbell , Stefano Stabellini , suravee.suthikulpanit@amd.com, xen-devel , Aravind Gopalakrishnan , Boris Ostrovsky List-Id: xen-devel@lists.xenproject.org >>> On 15.05.14 at 14:01, wrote: > At 12:56 +0100 on 15 May (1400154975), Jan Beulich wrote: >> >>> On 15.05.14 at 13:24, wrote: >> > Are there cases where we want to return EINTR to the guest, or could >> > we maybe use it everywhere and drop ERESTART? >> >> No, we need two distinct error codes on these paths. For now we >> never need to return -EINTR to the guest (and for now I also can't >> see when/why we would), but we'd have to convert these too >> should the need arise. > > I didn't really understand that. Do you mean that there's a reason to > have both EINTR and ERESTART even though we don't return EINTR to > guests, or that you want to keep them separate in case we ever do > want to return EINTR? The former. Jan