From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH v6 1/4] xen/arm: p2m: Clean cache PT when
 the IOMMU doesn't support coherent walk
Date: Thu, 15 May 2014 14:18:38 +0100
Message-ID: <5374DACE0200007800012AD1@mail.emea.novell.com>
References: <1400158608-9617-1-git-send-email-julien.grall@linaro.org>
	<1400158608-9617-2-git-send-email-julien.grall@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <JBeulich@suse.com>) id 1WkvYY-00074e-Do
	for xen-devel@lists.xenproject.org; Thu, 15 May 2014 13:18:42 +0000
In-Reply-To: <1400158608-9617-2-git-send-email-julien.grall@linaro.org>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com, ian.campbell@citrix.com, Xiantao Zhang <xiantao.zhang@intel.com>, tim@xen.org
List-Id: xen-devel@lists.xenproject.org

>>> On 15.05.14 at 14:56, <julien.grall@linaro.org> wrote:
> --- a/xen/include/xen/hvm/iommu.h
> +++ b/xen/include/xen/hvm/iommu.h
> @@ -34,6 +34,12 @@ struct hvm_iommu {
>      /* List of DT devices assigned to this domain */
>      struct list_head dt_devices;
>  #endif
> +
> +    /* Features supported by the IOMMU */
> +    unsigned long features;

This wants to be DECLARE_BITMAP(features, IOMMU_FEAT_count)
or some such, with ...

> --- a/xen/include/xen/iommu.h
> +++ b/xen/include/xen/iommu.h
> @@ -67,6 +67,14 @@ int iommu_map_page(struct domain *d, unsigned long gfn, unsigned long mfn,
>                     unsigned int flags);
>  int iommu_unmap_page(struct domain *d, unsigned long gfn);
>  
> +enum iommu_feature
> +{
> +    IOMMU_FEAT_COHERENT_WALK,

... IOMMU_FEAT_count added here.

> +};

Jan