From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v7 1/4] xen/arm: p2m: Clean cache PT when
 the IOMMU doesn't support coherent walk
Date: Thu, 15 May 2014 18:06:12 +0100
Message-ID: <5374F404.40909@linaro.org>
References: <1400163385-19863-1-git-send-email-julien.grall@linaro.org>
	<1400163385-19863-2-git-send-email-julien.grall@linaro.org>
	<537501C40200007800012C54@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1Wkz6m-0004qs-NI
	for xen-devel@lists.xenproject.org; Thu, 15 May 2014 17:06:16 +0000
Received: by mail-ee0-f43.google.com with SMTP id d17so864246eek.30
	for <xen-devel@lists.xenproject.org>;
	Thu, 15 May 2014 10:06:14 -0700 (PDT)
In-Reply-To: <537501C40200007800012C54@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com, ian.campbell@citrix.com, Xiantao Zhang <xiantao.zhang@intel.com>, tim@xen.org
List-Id: xen-devel@lists.xenproject.org

On 05/15/2014 05:04 PM, Jan Beulich wrote:
>>>> On 15.05.14 at 16:16, <julien.grall@linaro.org> wrote:
>> Some IOMMU don't suppport coherent PT walk. When the p2m is shared with
>> the CPU, Xen has to make sure the PT changes have reached the memory.
>>
>> Introduce new IOMMU function that will check if the IOMMU feature is enabled
>> for a specified domain.
>>
>> On ARM, the platform can contain multiple IOMMUs. Each of them may not
>> have the same set of feature. The domain parameter will be used to get the
>> set of features for IOMMUs used by this domain.
>>
>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> 
> IOMMU part:
> Acked-by: Jan Beulich <jbeulich@suse.com>

Thanks. Ian, will you take care to remove the "," in this patch? It will
avoid me to resend the whole series for this small change.

> with one final nit:
> 
>> --- a/xen/include/xen/iommu.h
>> +++ b/xen/include/xen/iommu.h
>> @@ -67,6 +67,15 @@ int iommu_map_page(struct domain *d, unsigned long gfn, 
>> unsigned long mfn,
>>                     unsigned int flags);
>>  int iommu_unmap_page(struct domain *d, unsigned long gfn);
>>  
>> +enum iommu_feature
>> +{
>> +    IOMMU_FEAT_COHERENT_WALK,
>> +    IOMMU_FEAT_count,

Regards,

-- 
Julien Grall