From mboxrd@z Thu Jan  1 00:00:00 1970
From: Zhigang Wang <zhigang.x.wang@oracle.com>
Subject: Re: `xl create` can not parse `disk =
 ['target=/tmp/disk.img, vdev=xvdb']`
Date: Fri, 16 May 2014 10:48:49 -0400
Message-ID: <53762551.1080206@oracle.com>
References: <53761D47.7030103@oracle.com>
	<1400249899.8259.74.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1400249899.8259.74.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 05/16/2014 10:18 AM, Ian Campbell wrote:
> On Fri, 2014-05-16 at 10:14 -0400, Zhigang Wang wrote:
>> Hi,
>>
>> `xl create` cannot parse::
>>
>>     disk = ['target=/tmp/disk.img,vdev=xvdb']
>>
>> Error::
>>
>>     # xl create vm.cfg 
>>     Parsing config from vm.cfg
>>     vm.cfg: config parsing error in disk specification: no vdev specified in `target=/tmp/disk.img,vdev=xvdb'
>>
>> But can parse::
>>
>>     disk = ['vdev=xvdb,target=/tmp/disk.img']
>>
>> Is this a bug?
> 
> No, it is expected, check the docs for the disk format strings.
> 
> (User questions should go to xen-users@)

Thanks for your answer.

I checked: http://xenbits.xen.org/docs/4.4-testing/misc/xl-disk-configuration.txt
 
And I think here is what you referred to:

    where each diskspec is in this form:
        
       [<key>=<value>|<flag>,]*,
         [<target>, [<format>, [<vdev>, [<access>]]]],
         [<key>=<value>|<flag>,]*
         [target=<target>]

That means disk positional parameter also has orders. I missed this point before.

Thanks,

Zhigang