xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Bob Liu <lliubbo@gmail.com>
Cc: keir@xen.org, ian.campbell@citrix.com, andrew.cooper3@citrix.com,
	xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com
Subject: Re: [RFC PATCH] xen: free_domheap_pages: delay page scrub to tasklet
Date: Mon, 19 May 2014 12:34:39 +0100	[thread overview]
Message-ID: <537A086F02000078000138C7@mail.emea.novell.com> (raw)
In-Reply-To: <1400468276-8683-1-git-send-email-bob.liu@oracle.com>

>>> On 19.05.14 at 04:57, <lliubbo@gmail.com> wrote:
> This patch try to delay scrub_one_page() to a tasklet which will be 
> scheduled on
> all online physical cpus, so that it's much faster to return from 'xl/xm
> destroy xxx'.

At the price of impacting all other guests. I think this is too simplistic
an approach. For one, I think the behavior ought to be configurable
by the admin: Deferring the scrubbing means you can't use the
memory for creating a new guest right away. And then you should
be doing this only on idle CPUs, or (with care not to introduce
security issues nor exhaustion of the DMA region) on CPUs actively
requesting memory, where the request can't be fulfilled without using
some of the not yet scrubbed memory.

And btw., 10 min of cleanup time for 1Tb seems rather much
independent of the specific scrubber behavior - did you check
whether decreasing the rate at which relinquish_memory() calls
hypercall_preempt_check() wouldn't already reduce this be quite
a bit?

Jan

  parent reply	other threads:[~2014-05-19 11:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-19  2:57 [RFC PATCH] xen: free_domheap_pages: delay page scrub to tasklet Bob Liu
2014-05-19  9:59 ` Andrew Cooper
2014-05-19 10:10 ` Konrad Rzeszutek Wilk
2014-05-19 11:34 ` Jan Beulich [this message]
2014-05-20  2:14   ` Bob Liu
2014-05-20  6:27     ` Jan Beulich
2014-05-20  7:11       ` Bob Liu
2014-05-20  7:26         ` Jan Beulich
2014-05-20  8:14           ` Bob Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=537A086F02000078000138C7@mail.emea.novell.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=ian.campbell@citrix.com \
    --cc=keir@xen.org \
    --cc=lliubbo@gmail.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).