From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v7 04/10] arch/arm: let map_mmio_regions() use start and count Date: Mon, 19 May 2014 14:47:36 +0100 Message-ID: <537A0B78.2000104@linaro.org> References: <1399305254-3695-1-git-send-email-avanzini.arianna@gmail.com> <1399305254-3695-5-git-send-email-avanzini.arianna@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1399305254-3695-5-git-send-email-avanzini.arianna@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Arianna Avanzini , xen-devel@lists.xen.org Cc: julien.grall@citrix.com, paolo.valente@unimore.it, keir@xen.org, stefano.stabellini@eu.citrix.com, tim@xen.org, dario.faggioli@citrix.com, Ian.Jackson@eu.citrix.com, Ian.Campbell@eu.citrix.com, etrudeau@broadcom.com, JBeulich@suse.com, andrew.cooper3@citrix.com, viktor.kleinik@globallogic.com List-Id: xen-devel@lists.xenproject.org On 05/05/2014 04:54 PM, Arianna Avanzini wrote: > diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c > index f88cddc..2c7f542 100644 > --- a/xen/arch/arm/p2m.c > +++ b/xen/arch/arm/p2m.c > @@ -511,12 +511,12 @@ int p2m_populate_ram(struct domain *d, > > int map_mmio_regions(struct domain *d, > unsigned long start_gfn, > - unsigned long end_gfn, > + unsigned long nr_mfns, > unsigned long mfn) > { > return apply_p2m_changes(d, INSERT, > pfn_to_paddr(start_gfn), > - pfn_to_paddr(end_gfn), > + pfn_to_paddr(start_gfn + nr_mfns + 1), This is wrong, apply_p2m_changes range is [spfn, epfn[. Here you will map one page more. This remark is also valid for unmap_mmio_regions in patch #7. Once you're series will be pushed in Xen upstream, I plan to rework apply_p2m_changes to use gfn + nr_pages which is less confusing and avoid using non aligned address as arguments (actually the function is assuming that the address is page-aligned). Regards, -- Julien Grall