xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Ian.Jackson@eu.citrix.com, Fabio Fantoni <fabio.fantoni@m2r.biz>
Cc: anthony.perard@citrix.com, xen-devel@lists.xensource.com,
	Ian Campbell <Ian.Campbell@citrix.com>,
	Stefano.Stabellini@eu.citrix.com
Subject: Re: [PATCH v2] libxl: add stdvga video memory setting with upstream qemu
Date: Mon, 19 May 2014 12:50:50 +0100	[thread overview]
Message-ID: <537A0C3A020000780001391F@mail.emea.novell.com> (raw)
In-Reply-To: <21369.60932.192728.638237@mariner.uk.xensource.com>

>>> On 19.05.14 at 13:41, <Ian.Jackson@eu.citrix.com> wrote:
> Fabio Fantoni writes ("Re: [PATCH v2] libxl: add stdvga video memory setting 
> with upstream qemu"):
>> Il 15/05/2014 18:00, Ian Campbell ha scritto:
>> > Acked + applied. I reworded the commit message a bit to:
>> >      libxl: add stdvga video memory setting with upstream qemu
>> >      
>> >      Currently we set the stdvga video memory with qemu-traditional only, 
> add the
>> >      necessary settings for qemu upstream too.
>> >      
>> >      Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
>> >      Acked-by: Ian Campbell <ian.campbell@citrix.com>
>> >
>> >
>> >
>> Thanks.
>> I think that this patch can be also backported to xen 4.4.
> 
> I think this falls on the bugfix side of the line, but:
> 
> I worry that it might cause regressions in existing setups, because it
> changes the interpretation of the domain config file (from a incorrect
> to a correct interpretation, but that is still a problem for a
> backport).
> 
> So I would be inclined not to backport this one.  I've added Jan, the
> hypervisor-side stable tree maintainer, in case he has a different
> view.

Help me understand the implications on the guest that this
changed (corrected) interpretation of the config file would have:
Would the guest see differing resources between reboots? Would
such differences also surface post-migration (which would pretty
clearly make this a no-go for a backport)?

Jan

  parent reply	other threads:[~2014-05-19 11:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-09 13:04 [PATCH v2] libxl: add stdvga video memory setting with upstream qemu Fabio Fantoni
2014-05-15 15:58 ` Ian Campbell
2014-05-15 15:59 ` Ian Campbell
2014-05-15 16:00 ` Ian Campbell
2014-05-19  8:44   ` Fabio Fantoni
2014-05-19 11:41     ` Ian Jackson
2014-05-09 12:55       ` [PATCH v2] libxl: fix cirrus vga " Fabio Fantoni
2014-05-15 16:00         ` Ian Campbell
2014-05-19  8:43           ` Fabio Fantoni
2014-05-19 11:43             ` [PATCH v2] libxl: fix cirrus vga video memory setting with upstream qemu [and 2 more messages] Ian Jackson
2014-05-19 11:50       ` Jan Beulich [this message]
2014-05-19 11:52         ` [PATCH v2] libxl: add stdvga video memory setting with upstream qemu Ian Jackson
2014-05-19 12:07           ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=537A0C3A020000780001391F@mail.emea.novell.com \
    --to=jbeulich@suse.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=fabio.fantoni@m2r.biz \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).