From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Blake Subject: Re: [Qemu-devel] [PATCH v3 02/16] x86: Convert debug printfs to QEMU_DPRINTF Date: Mon, 19 May 2014 09:35:50 -0600 Message-ID: <537A24D6.6050205@redhat.com> References: <1400367823-32610-1-git-send-email-marc.mari.barcelo@gmail.com> <1400367823-32610-3-git-send-email-marc.mari.barcelo@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6264259016035463034==" Return-path: In-Reply-To: <1400367823-32610-3-git-send-email-marc.mari.barcelo@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: =?UTF-8?B?TWFyYyBNYXLDrQ==?= , qemu-devel@nongnu.org Cc: Stefan Hajnoczi , Peter Crosthwaite , X86 , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , X86 List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============6264259016035463034== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nkiDhccAHdnRX2DPbufvAhhXrsoXWVFPT" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nkiDhccAHdnRX2DPbufvAhhXrsoXWVFPT Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/17/2014 05:03 PM, Marc Mar=C3=AD wrote: > Modify debug macros to have the same format through the codebase and us= e regular > ifs instead of ifdef. >=20 > Signed-off-by: Marc Mar=C3=AD > --- > hw/i386/kvm/pci-assign.c | 11 ++++++----- > hw/i386/multiboot.c | 7 +++++-- > target-i386/kvm.c | 9 +++++---- > xen-hvm.c | 9 +++++---- > xen-mapcache.c | 9 +++++---- > 5 files changed, 26 insertions(+), 19 deletions(-) >=20 > #ifdef DEVICE_ASSIGNMENT_DEBUG > -#define DEBUG(fmt, ...) \ > - do { \ > - fprintf(stderr, "%s: " fmt, __func__ , __VA_ARGS__); \ > - } while (0) > +#define DEVICE_ASSIGNMENT_DEBUG_ENABLED 1 > #else > -#define DEBUG(fmt, ...) > +#define DEVICE_ASSIGNMENT_DEBUG_ENABLED 0 > #endif > =20 > +#define DEBUG(fmt, ...) \ > + QEMU_DPRINTF(DEVICE_ASSIGNMENT_DEBUG_ENABLED, \ > + "pci_assign", fmt, ## __VA_ARGS__) > + Style - you are replacing aligned \ continuation with one-space \ continuation. I don't know if we have a distinct preference, but it's probably better to leave the style unchanged if checkpatch.pl doesn't complain about either way. As that's minor, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --nkiDhccAHdnRX2DPbufvAhhXrsoXWVFPT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTeiTWAAoJEKeha0olJ0NqnVgIAJ5mUeSBRNOzfVknaWiqfacQ aanMhm80CYF30PzC5qLXpcLTn3wQRBMSXtc81bUiO6JAL2dgkcfy6IMgVkJTmaR4 d2+XFBUcAIa9cKjFA4w1+v77lqtk8bkiKtfGWU33NVUa6VH/Hp+v4Me9LT/JebCl 8uT6nSdAiALsH4JmO6+pHB5D7vaF2SLXPZfFsCWBDqsyCVj18oREyle5NJjGpPUn 9hvTBijQGFBOs00i3tQBCMCy/M2lGGuafbeLwTGJbOXpQsjjeFAzjvo0ZwEKBBY8 2eB6+2JVsk36LkbzJPx9fvebvnOTJF6LLHAuxZFC0fRoSWkqRltME2YypEO8gVQ= =gXPa -----END PGP SIGNATURE----- --nkiDhccAHdnRX2DPbufvAhhXrsoXWVFPT-- --===============6264259016035463034== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============6264259016035463034==--